Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip ingester tailer filtering if no filter is set #1084

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Skip ingester tailer filtering if no filter is set #1084

merged 1 commit into from
Sep 30, 2019

Conversation

pracucci
Copy link
Contributor

What this PR does / why we need it:

In the (probably unfrequent) case no filter is set (ie. query {type="test"}), there's no need to go through all log entries filtering while tailing in filterEntriesInStream().

Checklist

  • Documentation added
  • Tests updated

sandeepsukhani
sandeepsukhani approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this.

@sandeepsukhani sandeepsukhani merged commit 42040f2 into grafana:master Sep 30, 2019
@pracucci pracucci deleted the ingester-tailer-filter-stream-optimization branch September 30, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeepsukhani sandeepsukhani sandeepsukhani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pracucci @sandeepsukhani